Skip to content

Bump openwrt-luci-rpc version to 1.1.17#112796

Merged
frenck merged 1 commit into
home-assistant:devfrom
mrchi:bump-openwrt-luci-rpc
Mar 12, 2024
Merged

Bump openwrt-luci-rpc version to 1.1.17#112796
frenck merged 1 commit into
home-assistant:devfrom
mrchi:bump-openwrt-luci-rpc

Conversation

@mrchi
Copy link
Copy Markdown
Contributor

@mrchi mrchi commented Mar 9, 2024

Proposed change

Update response parsing of get_all_connected_devices RPC call for OpenWrt 23.05.

Diff: fbradyirl/openwrt-luci-rpc@v1.1.16...v1.1.17

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant Bot added the bugfix label Mar 9, 2024
Copy link
Copy Markdown
Contributor

@home-assistant home-assistant Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mrchi

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant Bot added cla-needed dependency Pull requests marked as a dependency upgrade integration: luci small-pr PRs with less than 30 lines. labels Mar 9, 2024
@home-assistant home-assistant Bot marked this pull request as draft March 9, 2024 05:24
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Mar 9, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Mar 9, 2024

Hey there @mzdrale, mind taking a look at this pull request as it has been labeled with an integration (luci) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of luci can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign luci Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@Kane610
Copy link
Copy Markdown
Member

Kane610 commented Mar 9, 2024

Hello. Please provide a diff of the changes coming with the library bump

@mrchi
Copy link
Copy Markdown
Contributor Author

mrchi commented Mar 9, 2024

Hello. Please provide a diff of the changes coming with the library bump

Done, please review again:)

@Kane610
Copy link
Copy Markdown
Member

Kane610 commented Mar 9, 2024

Hello. Please provide a diff of the changes coming with the library bump

Done, please review again:)

Where can I see the link to the diff?

@mrchi
Copy link
Copy Markdown
Contributor Author

mrchi commented Mar 9, 2024

Hello. Please provide a diff of the changes coming with the library bump

Done, please review again:)

Where can I see the link to the diff?

Sorry, I misunderstood what you meant. I thought you wanted the changelog, so I wrote it in the PR description.

Here is the diff link fbradyirl/openwrt-luci-rpc@v1.1.16...v1.1.17

@frenck frenck added this to the 2024.3.1 milestone Mar 12, 2024
@frenck frenck merged commit 182a1fe into home-assistant:dev Mar 12, 2024
@frenck
Copy link
Copy Markdown
Member

frenck commented Mar 12, 2024

Thanks, @mrchi 👍

../Frenck

@mrchi mrchi deleted the bump-openwrt-luci-rpc branch March 13, 2024 00:32
@frenck frenck mentioned this pull request Mar 13, 2024
xeniter pushed a commit to xeniter/core that referenced this pull request Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix cherry-picked cla-signed dependency Pull requests marked as a dependency upgrade integration: luci Quality Scale: No score small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Luci device tracker: AttributeError: 'list' object has no attribute 'upper'

4 participants